Hi Lance,

In DriverManagerModuleTests, at line 83, did you mean to assign the result of DM::getDriver to d2 although an Exception is expected?

Otherwise, the patch looks good to me.

Best,
Joe

On 5/2/2017 11:33 AM, Lance Andersen wrote:
Hi all,

The above issue adds a  test  to verify that a module based JDBC driver works 
via the service-provider loading mechanism.

The webrev can be found at 
http://cr.openjdk.java.net/~lancea/8078267/webrev.00/index.html 
<http://cr.openjdk.java.net/~lancea/8078267/webrev.00/index.html>

Best
Lance
  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
  <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>




Reply via email to