Hi Daniel, Thank you for the info. I do plan on adding some additional tests using these modules. I did run into some challenges with testng/jtreg/modules/TEST.properties that I am trying to sort out overall before I do that.
Best Lance > On May 3, 2017, at 10:05 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Lance, > > Are you planning to use these modules in other tests? > I'm asking because you're using the @library tag to compile them. > If you want to encapsulate a module inside a test (without resorting > to @library) then you can do so with the following layout and > following @build line: > > <jdk>/test/..../mytest/MyDriverTest.java > <jdk>/test/..../mytest/mymodule/module-info.java > <jdk>/test/..../mytest/mymodule/x/y/Z.java > > @build mymodule/x.y.Z MyDriverTest > > hope this helps, > > -- daniel > > On 03/05/2017 01:49, Lance Andersen wrote: >> Hi Joe, >> >>> On May 2, 2017, at 8:34 PM, huizhe wang <huizhe.w...@oracle.com> wrote: >>> >>> Hi Lance, >>> >>> In DriverManagerModuleTests, at line 83, did you mean to assign the result >>> of DM::getDriver to d2 although an Exception is expected? >> I must have accidentally deleted that and never noticed it due to the >> SQLException being thrown. >> >> I will add it prior to pushing. >> >>> >>> Otherwise, the patch looks good to me. >> >> Thank you >> >> Best >> Lance >>> >>> Best, >>> Joe >>> >>> On 5/2/2017 11:33 AM, Lance Andersen wrote: >>>> Hi all, >>>> >>>> The above issue adds a test to verify that a module based JDBC driver >>>> works via the service-provider loading mechanism. >>>> >>>> The webrev can be found at >>>> http://cr.openjdk.java.net/~lancea/8078267/webrev.00/index.html >>>> <http://cr.openjdk.java.net/~lancea/8078267/webrev.00/index.html> >>>> >>>> Best >>>> Lance >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >>>> Principal Member of Technical Staff | +1.781.442.2037 >>>> Oracle Java Engineering >>>> 1 Network Drive >>>> Burlington, MA 01803 >>>> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> >>>> >>>> >>>> >>> >> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >> Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> >> >> >> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
