> On 5 Nov 2017, at 16:55, David Holmes <david.hol...@oracle.com> wrote: > > On 4/11/2017 7:28 AM, Paul Sandoz wrote: >>> On 3 Nov 2017, at 11:14, Karen Kinnear <karen.kinn...@oracle.com> wrote: >>> 6. SD::find_java_mirror_for_type >>> You have resolve_or_null/fail doing CHECK_(empty) which should >>> check for a NULL constant_type_klass. This is followed by an explicit if >>> (constant_type_klass == NULL) — is that needed? >>> >> Can SD:resolve_or_null return a null value when HAS_PENDING_EXCEPTION=false? > > I don't believe it actually can - the only reason you would get NULL is if > something went wrong, for which an exception must be pending. However, even > the internal implementation underlying this seems unclear on that point
Right, i am gonna leave things as they are for now unless we come up with a more definitive answer. Paul. > e.g in SystemDictionary::resolve_instance_class_or_null we have: > > if (HAS_PENDING_EXCEPTION || k == NULL) { > return NULL; > } > > David > ——