> On 31 Oct 2017, at 14:43, mandy chung <mandy.ch...@oracle.com> wrote: > > > > On 10/26/17 10:03 AM, Paul Sandoz wrote: >> Hi, >> >> Please review the following patch for minimal dynamic constant support: >> >> >> http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8186046-minimal-condy-support-hs/webrev/ >> >> <http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8186046-minimal-condy-support-hs/webrev/> > > > I reviewed the non-hotspot change as a learning exercise (I am not close to > j.l.invoke implementation). I assume DynamicConstant intends to be > non-public in this patch, right? > 30 public final class DynamicConstant >
Well spotted. More likely to be renamed to ConstantBootstraps when a minimal set of dynamic constant bootstraps will be proposed (likely this week) as a follow on patch. I’ll made it non-public in the updated webrev so as to keep this patch self-contained. Paul.
