Updated patch:

http://cr.openjdk.java.net/~bpb/4358774/webrev.01/

On Dec 7, 2017, at 6:08 AM, Alan Bateman <alan.bate...@oracle.com> wrote:

> If nothing else, a private ensureOpen method would make it easier to read so 
> that the "if (closed) throw ..." isn't needed in every method.

Done.

On Dec 6, 2017, at 7:03 PM, Vitaly Davidovich <vita...@gmail.com> wrote:

> From a performance angle, I'd be more concerned with the calls to 
> Objects.xyz() methods there.  Unless something has changed in the JIT 
> recently, those are susceptible to profile pollution and can cause missed 
> optimizations.  I'd inline those methods manually to give these methods their 
> own profiles.

Done.

Thanks,

Brian

Reply via email to