Looks great! Personally, these LogManager startup issues make my head hurt. :)
Jason ________________________________________ From: Daniel Fuchs <daniel.fu...@oracle.com> Sent: Tuesday, January 23, 2018 1:13 PM To: Jason Mehrens; core-libs-dev@openjdk.java.net Cc: Mandy Chung Subject: Re: [JDK 11] RFR: 8195096: Exception printed on console with custom LogManager on starting Apache Tomcat Hi Jason, I take it back :-) Mandy helped me finding better names to refactor the code, so here is a (hopefully) better version: http://cr.openjdk.java.net/~dfuchs/webrev_8195096/webrev.02/ best regards, -- daniel On 23/01/2018 10:27, Daniel Fuchs wrote: > Hi Jason, > > On 22/01/2018 21:30, Jason Mehrens wrote: >> Daniel, >> >> Fantastic! The patch looks good as is. The only > thing that sticks >> out is that both the 'if' and >> the 'else if' have the same code inside them. >> That could be refactored a bit. > > I had the same feeling - but then when looking at > possible refactoring I came to the conclusion that > I liked the explicit if / else if / better. > > The duplicated code is just one line + one return > so it's not that bad. > > best regards, > > -- daniel > >> >> Jason >
