Thanks, Mandy, changeset pushed. We are in agreement. On Thu, Feb 15, 2018 at 7:31 PM, mandy chung <mandy.ch...@oracle.com> wrote:
> > > On 2/15/18 7:13 PM, Martin Buchholz wrote: > > > > On Thu, Feb 15, 2018 at 3:20 PM, mandy chung <mandy.ch...@oracle.com> > wrote: > >> >> I have posted RFR to remove runFinalizersOnExit. I think your patch >> would become cleaner as you may keep the remove method or inline in >> runFinalizer method as your original patch has. >> >> Do you want to wait until JDK-8198249? or proceed this patch without >> waiting? >> > > I'd like to commit this patch now, in part because we're actually > backporting this as a local patch to make race detection easier. > > Regarding remove(), I think it's actually cleaner inline, but if it's kept > a separate method, then make it return a boolean, as with Collection remove > methods. > > > http://cr.openjdk.java.net/~martin/webrevs/jdk/Finalizer-data-race/ > > I reviewed this version. It looks okay. > > With the removal of runFinalizersOnExit, I will inline the deregistration > part as part of runFinalizers after I rebase with your change. Hope that's > okay with you. > > Mandy >
