Hi, Stuart. I think you need to make changes to this file too:
http://hg.openjdk.java.net/jdk/jdk/file/tip/src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html Thanks, iris -----Original Message----- From: Alan Bateman Sent: Wednesday, June 6, 2018 3:40 AM To: Stuart Marks <[email protected]>; serviceability-dev <[email protected]> Cc: core-libs-dev <[email protected]> Subject: Re: RFR(s): 8204243: remove Thread.destroy() and Thread.stop(Throwable) On 06/06/2018 01:05, Stuart Marks wrote: > [adding serviceability-dev] > > Hi serviceability folks, > > I'm in the process of removing Thread.destroy() and > Thread.stop(Throwable) from the Java SE API. Alan and David have > pointed out that there are some cross-references to > Thread.stop(Throwable) in the JDWP and JVMTI specs, as well as in the > JDI ThreadReference API. I've adjusted the relevant files. > > See please review this updated webrev: > > http://cr.openjdk.java.net/~smarks/reviews/8204243/webrev.1/ Have you considered removing the "What about Thread.stop(Throwable)" section completely from the threadPrimitiveDeprecation doc? A new developer reading the javadoc in 2019 shouldn't need to read about a removed method. Otherwise I think this looks good, including the updates to the JDWP and JVM TI specs. -Alan
