+1
On 6/26/18, 12:49 PM, Joe Wang wrote:
On 6/26/18, 11:57 AM, Alan Bateman wrote:
On 26/06/2018 18:41, Joe Wang wrote:
:
Yes, combined with Sherman's suggestion eliminated the need for the
new parameter. Here's the updated webrev:
http://cr.openjdk.java.net/~joehw/jdk11/8205058/webrev03/
This looks good.
Just a minor nit but newStringNoRepl and getBytesNoReply don't need
to check if the cause is null.
Removed the null check. The internal impl and test guarantees it's not
null indeed:
http://cr.openjdk.java.net/~joehw/jdk11/8205058/webrev04/
Thanks,
Joe
-Alan