RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

[Baesken, Matthias]

Hi  Max, probably   we should add  the  info about the MANIFEST.MF  , for 
example :
 change  getErrorPosition  to 

http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.7/src/java.base/share/classes/java/util/jar/Attributes.java.udiff.html


    static String getErrorPosition(String filename, final int lineNumber) {
        if (filename == null || !jarPathInExceptionText) {
            return "META-INF/MANIFEST.MF  line:" + lineNumber;
       }

       final File file = new File(filename);
        return AccessController.doPrivileged(new PrivilegedAction<String>() {
            public String run() {
                return file.getAbsolutePath() + "!META-INF/MANIFEST.MF  line:" 
+ lineNumber;
         }
   .....


Best regards, Matthias



> -----Original Message-----
> From: Weijun Wang <weijun.w...@oracle.com>
> Sent: Donnerstag, 30. August 2018 16:04
> To: Baesken, Matthias <matthias.baes...@sap.com>
> Cc: Alan Bateman <alan.bate...@oracle.com>; Sean Mullan
> <sean.mul...@oracle.com>; Chris Hegarty <chris.hega...@oracle.com>;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
> 
> 
> 
> > On Aug 30, 2018, at 8:26 PM, Baesken, Matthias
> <matthias.baes...@sap.com> wrote:
> >
> >> - What will the output look like? Is it "/tmp/x.jar:100"?
> >>
> >
> > Yes it look like this :
> >
> > line too long (/testdata/jars/file_with_long_line_1.jar:2)
> 
> Is this a little misleading? I think you mean
> 
>    /testdata/jars/file_with_long_line_1.jar!META-INF/MANIFEST.MF:2
> 
> Thanks
> Max