Hi David, I think we need some form of test, as Alan indicated.
java/lang/ProcessBuilder/Basic.java should run through. Actually, I would like it if we would run this test for all valid enabled launch mechanisms, regardless which one is default. Can this be done? To save time I will only rerun the tests once all reviews are completed and the test is added. Thanks, Thomas On Wed, Oct 24, 2018 at 3:36 PM David Lloyd <david.ll...@redhat.com> wrote: > > On Wed, Oct 24, 2018 at 1:05 AM Thomas Stüfe <thomas.stu...@gmail.com> wrote: > > Review: > > > > - copyright dates need updating on the C-sources > > > > - I opt for "#if defined(__solaris__) || defined(_ALLBSD_SOURCE) || > > defined(_AIX) || defined(__linux__)" to be removed completely from > > unix-specific source files. The ifdef now covers all OpenJDK Unix > > platforms. > > Here's a version with these changes. > > -- > - DML
