Hi David,
On 11/8/18 11:00 PM, David Holmes wrote:
Hi Vicente,
On 9/11/2018 2:39 AM, Vicente Romero wrote:
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible
to see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was trying to see
how/where that appeared but its somewhat obscure. Oh well.
Is it that case that the code the uses the ASM library, like the JFR
code and jlink code, and the tests, doesn't actually _have to_
change to specifying Opcodes.ASM7 unless they plan on using ASM7
features?
I changed only the tests for which the new ASM was complaining about
a particular API available only for ASM7
I could not understand how this could be if the tests and other code
were unchanged, so I applied the ASM-only patch and investigated the
first failure running nasgen. And of course the problem is the
NestHost/NestMembers attributes! We modified our internal version of
ASM to add nestmate support, but of course this update removes that
and replaces it with the official support. But the official support is
only enabled for ASMv7 so we must update all users of ASM to request
version 7.
thanks for double checking this
Thanks,
David
-----
Vicente
If so then you could split out the actual update of ASM from the
updates to the users of ASM (some of which may be quite fine with
ASM5).
I have made two webrevs to make the review easier [1], contain only
the changes to the internal asm and [2] contains the changes to the
clients plus make files, legal, etc. I have also made the changes to
ClassWriterExt and affected test proposed by Igor in another mail,
Thanks,
David
Thanks,
Vicente
[1] http://cr.openjdk.java.net/~vromero/8213480/webrev.asm.7.only.00/
[2]
http://cr.openjdk.java.net/~vromero/8213480/webrev.asm.7.additional.changes.00/
On 8/11/2018 1:56 AM, Vicente Romero wrote:
Hi,
Version 7.0 of ASM has been released. This version supports condy,
yay!, and we want to include it in JDK 12. Please review [1] which
includes:
- the new version perse substituting the preview ASM internal
version in the JDK
- changes to additional files in particular some tests, mostly
hotspot tests.
Thanks,
Vicente
[1] http://cr.openjdk.java.net/~vromero/8213480/webrev.00/
