Hi Roger, Thanks for the suggestions. Version 7
http://cr.openjdk.java.net/~bpb/6516099/webrev.07/ is updated in place with this diff: --- a/src/java.base/share/classes/java/io/InputStream.java +++ b/src/java.base/share/classes/java/io/InputStream.java @@ -579,6 +579,7 @@ * when this method was invoked. * @throws IOException if the stream cannot be positioned properly or * if an I/O error occurs. + * @see java.io.InputStream#skip(long) */ public void skipNBytes(long n) throws IOException { if (n > 0) { @@ -595,7 +596,7 @@ throw new EOFException(); } } else if (ns != n) { // skipped negative or too many bytes - throw new IOException(); + throw new IOException("Unable to skip exactly"); } } } Thanks, Brian > On Nov 15, 2018, at 8:23 AM, Roger Riggs <roger.ri...@oracle.com> wrote: > > Looking good. > > I would add a message to the thrown IOException @598: "Unable to skip > exactly". > > Adding a @see to skip(n) would be a good addition to recommend using > skipNBytes.
