Hi Thomas,

Looks pretty good.

Usually 'we' avoid the first person writing in the jira.
It makes them more readable in the long term, when there is no context for 'we'.

- Describing it as 'experimental' gives the wrong impression
and has some magnified implications as that term is being used for
other major changes.

- The compatibility risk should be corrected:

Supplying an unknown value on the command line produces a java.lang.Error.

% java -Djdk.lang.Process.launchMechanism=POSIX_SPAWN ...

java.lang.Error: POSIX_SPAWN is not a supported process launch mechanism on this platform.

- Since CSRs should be self contained, the specification section should explicitly specify the behavior from the API point of view. CSRs should avoid describing
the implementation (though in this case, its not entirely possible).
The webrev of the impl is not relevant.

Thanks, Roger


On 11/30/2018 03:32 AM, Thomas Stüfe wrote:
CSR for jdk12: https://bugs.openjdk.java.net/browse/JDK-8214511

..Thomas


Reply via email to