Hi Adam,
The patch looks fine.
Once the patch is committed, the zip file attached to the issue
has no purpose and is just wasted space.
Attaching the patch would waste less space but still be redundant.
Best practice is to put the webrev's on cr.openjdk.java.net.
A link from the issue to the email thread on openjdk.java.net
is also helpful.
$.02, Roger
On 12/13/2018 07:23 AM, Adam Farley8 wrote:
Update: The revised webrev can be found here:
http://cr.openjdk.java.net/~afarley/8215217/webrev/
It can also be found in the zip attached to the bug.
Best Regards
Adam Farley
IBM Runtimes
Adam Farley8/UK/IBM wrote on 13/12/2018 11:49:12:
From: Adam Farley8/UK/IBM
To: Stuart Marks <stuart.ma...@oracle.com>
Cc: core-libs-dev@openjdk.java.net, mark.reinh...@oracle.com
Date: 13/12/2018 11:49
Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words
Hi Stuart,
A good compromise. Well referenced.
Yes, could you sponsor this change?
Thanks,
- Adam
Stuart Marks <stuart.ma...@oracle.com> wrote on 12/12/2018 00:38:32:
...
# HG changeset patch
# User afarley
# Date 1544574289 28800
# Tue Dec 11 16:24:49 2018 -0800
# Node ID 0c40c78b6d139eb05b0718d0b524a465419ee9cb
# Parent b75a44aad06cd93c823159265a1f200bf0ce390c
8215217: OpenJDK Source Has Too Many Swear Words
diff -r b75a44aad06c -r 0c40c78b6d13
src/java.desktop/share/classes/com/sun/media/sound/SoftChannel.java
--- a/src/java.desktop/share/classes/com/sun/media/sound/
SoftChannel.java Tue
Dec 11 13:10:14 2018 -0800
+++ b/src/java.desktop/share/classes/com/sun/media/sound/
SoftChannel.java Tue
Dec 11 16:24:49 2018 -0800
@@ -1472,7 +1472,7 @@
}
for (int controller : co_midi_nrpn_nrpn.keySet())
nrpnChange(controller, 0);
- rpnChange(0, 2 << 7); // Bitch Bend sensitivity
+ rpnChange(0, 2 << 7); // Pitch Bend sensitivity
rpnChange(1, 64 << 7); // Channel fine tunning
rpnChange(2, 64 << 7); // Channel Coarse Tuning
rpnChange(5, 64); // Modulation Depth, +/- 50
cent
diff -r b75a44aad06c -r 0c40c78b6d13
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/
dom/BitArray.java
---
a/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/
xsltc/dom/BitArray.java
Tue Dec 11 13:10:14 2018 -0800
+++
b/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/
xsltc/dom/BitArray.java
Tue Dec 11 16:24:49 2018 -0800
@@ -133,7 +133,7 @@
* This method returns the Nth bit that is set in the bit array.
The
* current position is cached in the following 4 variables and
will
* help speed up a sequence of next() call in an index iterator.
This
- * method is a mess, but it is fast and it works, so don't
fuck with it.
+ * method is a mess, but it is fast and it works, so don't change
it.
*/
private int _pos = Integer.MAX_VALUE;
private int _node = 0;
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with
number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
