Looks fine and trivial. Note that this may not be enough for windows 32bit. Highest I can go there (win32 slowdebug build I just built) is 1400m.
Cheers, Thomas On Mon, Mar 25, 2019 at 3:33 PM Aleksey Shipilev <sh...@redhat.com> wrote: > Bug: > https://bugs.openjdk.java.net/browse/JDK-8221400 > > My major concern is to make tier1 passing on x86_32. This is one of the > tests that fail. It seems > the test can just use smaller heap size. > > Fix: > > diff -r d25b24c70126 test/jdk/java/lang/String/StringRepeat.java > --- a/test/jdk/java/lang/String/StringRepeat.java Mon Mar 25 00:57:03 2019 > -0400 > +++ b/test/jdk/java/lang/String/StringRepeat.java Mon Mar 25 12:24:08 2019 > +0100 > @@ -22,11 +22,11 @@ > */ > > /* > * @test > * @summary This exercises String#repeat patterns and limits. > - * @run main/othervm -Xmx4G StringRepeat > + * @run main/othervm -Xmx2g StringRepeat > */ > > import java.nio.CharBuffer; > > > Testing: Linux {x86_64, x86_32} fastdebug build and test, jdk-submit > > Thanks, > -Aleksey > >
