Hi Raffaello, et. al. > On Apr 3, 2019, at 7:43 AM, Raffaello Giulietti > <raffaello.giulie...@gmail.com> wrote: > > in this patch there are additional white-box tests against critical package > private entities in the jdk.internal.math classes. In particular the class > jdk.internal.math.MathUtils is thoroughly tested. > > Also, the tag @key randomness is now used along jdk.test.lib.RandomFactory.
Good. > To run the tests > make test TEST="jtreg:test/jdk/jdk/internal/math/ToDecimal” As a note to anyone else running these, I configured my OpenJDK build as bash ./configure --with-jtreg=$JTREG_HOME where $JTREG_HOME is the location of the unpacked jtreg archive. The tests passed, as expected: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/jdk/internal/math/ToDecimal 3 3 0 0 ============================== TEST SUCCESS > Brian Burkhalter, my sponsor, will soon publish the patch in webrev form. Done [1]. > Of course, if anybody would like to step forward as a reviewer I'll be glad > to help. Any reviews would of course be most welcome, both of the patch itself, and of the CSR [2], provided for the latter one has a JBS login. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/4511638/webrev.02/ [2] https://bugs.openjdk.java.net/browse/JDK-8202555
