On 11/04/2019 11:34, Alan Bateman wrote: > On 10/04/2019 12:15, Andrew Dinn wrote: >> : >> An updated webrev is available: >> >> JIRA: https://bugs.openjdk.java.net/browse/JDK-8221696 >> webrev: http://cr.openjdk.java.net/~adinn/8221696/webrev.01 >> >> > The updated javadoc looks good. A minor nit is that it reads "and > includes {@code length} bytes" when it should say "and is {@code length} > bytes". There is also a stray quote at the end of the paragraph.
Ok, I have corrected that and will update the patch accordingly > I've added myself as Reviewer to the CSR so you can finalize it. Excellent, thank you. It has now been finalized. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander