Looks good to me.
I took some extra care to check that use of new Integer in
MultiReleaseJarTest wasn't intentional but that doesn't seem to be the
case here.
Thanks!
/Claes
On 2019-04-26 14:35, Langer, Christoph wrote:
Hi,
please help reviewing these cleanups to the zipfs tests. In detail:
- Fix warnings in test/jdk/jdk/nio/zipfs/Demo.java (not a real testcase
but Demo coding)
- change some calls of Runtime.version().major() to
Runtime.version().feature() (the former is deprecated)
- change occurences of new Integer() to Integer.valueOf()
- change occurences of class.newInstance() to
class.getDeclaredConstructor().newInstance()
- remove unused variables
- move test/jdk/jdk/nio/zipfs/jarfs/JFSTester.java to
test/jdk/jdk/nio/zipfs/JFSTester.java (not using the jarfs subfolder).
There is no need for this specific subfolder, given that
MultiReleaseJarTest.java neither isn't in the jarfs subfolder
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223015.0/
Bug: https://bugs.openjdk.java.net/browse/JDK-8223015
I verified that the tests still succeed with the change.
Thanks
Christoph
