Hi Andrew,
On 05/24/2019 07:06 AM, Andrew Dinn wrote:
Ping!
Any takers for a review?
I found some trailing space in v5 and it seems they are in v6 as well.
You might want to check the followings:
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
+ // data cache line writeback
+ StubRoutines::_data_cache_writeback = generate_data_cache_writeback();
+ StubRoutines::_data_cache_writeback_sync =
generate_data_cache_writeback_sync();
+ <-- here
src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
+ if (_dcpop || UsePOCForPOP) {
+ _data_cache_line_flush_size = dcache_line;
+ }
+ }
+ <-- here
src/hotspot/cpu/x86/macroAssembler_x86.cpp
+ // no need for fence when using CLFLUSH
+ clflush(line);
+ } <-- here
src/hotspot/cpu/x86/stubGenerator_x86_64.cpp
in generate_data_cache_writeback():
+ __ ret(0);
+
+ return start; <-- here
in generate_data_cache_writeback_sync():
+ __ jcc(Assembler::notEqual, skip); <-- here
and
+ // data cache line writeback
+ StubRoutines::_data_cache_writeback = generate_data_cache_writeback();
+ StubRoutines::_data_cache_writeback_sync =
generate_data_cache_writeback_sync();
+ <-- here (like in aarch64 file)
src/java.base/share/classes/java/nio/MappedByteBuffer.java
+ private final boolean isSync;
+ <-- here
and
+ private boolean isSync() {
+ return isSync;
+ }
+ <-- here
src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+ * that must be guaranteed written back to memory.
+ * <-- here
and here:
+ * @since 13
+ */
+ <-- here
+ checkSize(length);
+ }
+ <-- here
+ * calling method {@link writeback #writeback} if it is disabled).
+ * <-- here
+ throw new RuntimeException("writebackMemory not enabled!");
+ }
+ }
+ <-- here
+ // following memory writes
+ @HotSpotIntrinsicCandidate
+ private native void writebackPostSync0();
+ <-- here
src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java
+ incrementStats();
+ }
+ <-- here
totalCapacity -= cap;
}
}
}
+ <-- here
+ super(address, size, cap, fd);
+ incrementStats();
+ }
+ <-- here
+ totalCapacity -= cap;
+ }
+ }
+ }
+ <-- here
src/java.base/unix/native/libnio/ch/FileChannelImpl.c
+ // should never be called with map_sync and prot == PRIVATE
+ assert((prot != sun_nio_ch_FileChannelImpl_MAP_PV) ||! map_sync);
+ <-- here
+#ifndef MAP_SHARED_VALIDATE
+#define MAP_SHARED_VALIDATE 0x03
+#endif
+ <-- here
test/jdk/java/nio/MappedByteBuffer/PmemTest.java
+import com.sun.nio.file.ExtendedMapMode;
+ <-- here
+ public static final int NUM_KBS = 16;
+ <-- here
Best regards,
Gustavo