On 18/06/2019 17:15, Andrew Dinn wrote:
Could I please have a review for the following trivial change to the
javadoc for the two MappedByteBuffer.force methods:
JIRA: https://bugs.openjdk.java.net/browse/JDK-8226203
webrev: http://cr.openjdk.java.net/~adinn/8226203/webrev.00/
It allows for the possibility of failures when extended map modes are
used to create the MappedByteBuffer.
The case documented here will not actually arise in JDK13 since nothing
in the JDK creates, let alone exposes extended map modes. However, it
would be better if the javadoc reflected that possibility. Is it still
possible to push this? If that is a problem then I am happy for it to go
into jdk14.
This looks good. Will you create a CSR for this? I think it can be fixed
in jdk/jdk13 as it follows JDK-8221397 and JDK-8221696 (and there is no
risk as it's javadoc only).
-Alan
