On 21/06/2019 10:42, Andrew Dinn wrote:
: + * <p> If this buffer was not mapped in read/write mode + * ({@link java.nio.channels.FileChannel.MapMode#READ_WRITE}) + * then invoking this method may have no effect. In particular, + * the method has no effect for buffers mapped in read-only or + * private mapping modes. This method may or may not have an + * effect for implementation-specific mapping modes. </p>Would you agree with that change or do you prefer to stick with the original? If necessary I'll amend the patch and CSR then push whichever version you prefer to JDK13.
I saw Joe's comment on the CSR. This refinement looks good to me. -Alan
