Hi Mandy, On Wed, Jul 3, 2019, 00:20 Mandy Chung <mandy.ch...@oracle.com> wrote:
> Hi Thomas, > > This is AIX-only. It would be cleaner to move AIX-specific launcher > to a new file like main_aix.c. Have you considered that? > I rather not since this would unnecessarily increase complexity even further. However, if you really dislike the platform specific code, I would withdraw the patch and just disable the test on AIX. I was on the fence about that anyway. Cheers, Thomas > > I don't know how to specify additional .c file in > make/test/JtregNativeJdk.gmk though. > > Mandy > > > > On 7/1/19 10:23 PM, Thomas Stüfe wrote: > > Second, corrected Webrev: > > > > > http://cr.openjdk.java.net/~stuefe/webrevs/execalleraccesstest-cannot-launch-on-primordial-thread/webrev.01/webrev/ > > > > Run through SAP nightlies on all platforms. > > > > Cheers, Thomas > > > > > > On Thu, Jun 27, 2019 at 9:02 AM Thomas Stüfe <thomas.stu...@gmail.com> > > wrote: > > > >> Hi all, > >> > >> Issue: > >> https://bugs.openjdk.java.net/browse/JDK-8226863 > >> webrev: > >> > >> > http://cr.openjdk.java.net/~stuefe/webrevs/8226863--jdk-java-lang-reflect-execalleraccesstest-cannot-launch-on-primordial-thread/webrev.00/webrev/ > >> > >> we have this annoying issue on AIX that the libjvm cannot be invoked on > a > >> primordial thread. Therefore we need to change launchers which create > the > >> VM to spawn own threads (we only do this where it is worth the effort - > >> this, admittedly, is a corner case, we could alternatively just disable > the > >> test on AIX). > >> > >> This is annoying and vaguely embarrassing :-/ Maybe IBM will step in > some > >> time and help us solve the underlying issues which have to do with the > >> inability to create guard pages on the primordial thread stack (among > other > >> things IIRC). > >> > >> Thanks for reviewing, > >> > >> Thomas > >> > >> > >> > >
