Hello,

Please review a small patch that mostly fixes jpackage test for Linux aarch64 and also arm,x86,power. It is prepared for 'JDK-8200758-branch' branch of open 'sandbox' repo.

There are few parts:

1. LinuxPlatform.cpp and IniFile.cpp got small fixes for compiler warnings.

2. LinuxDebBundler.getArch() now maps only x86_64 to amd64, x86 is still mapped to i386, and other archs map to themselves.

3. In tests, new method getRpmArch() was added to linux/base/Base.java, it maps JVMs os.arch to default rpmbuild arch. Multiple tests were modified to use that method instead of "x86_64" in rpm file name. Some timeouts were increased.

bug: https://bugs.openjdk.java.net/browse/JDK-8222778

webrev: http://cr.openjdk.java.net/~dchuyko/8222778/webrev.00/

testing: test/jdk/tools/jpackage jtreg tests pass on Ubuntu 16.04 with rpmbuild on x86_64, aarch64, arm, x86 and power, except deb/MaintainerTest (fails everywhere similarly to x86_64 because of extra "Unknown" name in email).

I didin't cover s390 as we in BellSoft currently don't build on that arch. On typical armv7 hw increased or default timeouts are still too low, while they are fine for some relatively weak aarch64 machines. Deb tests run especially slow because of dpkg-deb itself. I used "force-unsafe-io" option in /etc/dpkg/dpkg.cfg, it does reduce packaging time but still not enough to have really fast tests.

-Dmitry


Reply via email to