> On Jul 23, 2019, at 8:27 AM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > >> On Jul 23, 2019, at 8:20 AM, Alan Bateman <alan.bate...@oracle.com >> <mailto:alan.bate...@oracle.com>> wrote: >> >> On 23/07/2019 16:08, Brian Burkhalter wrote: >>> >>> I don’t see what you mean. >>> @Override >>> public void write(byte buf[]) throws IOException { >>> super.write(buf); >>> } >>> Should “trouble” be set and the IOE re-thrown? >>> >> super.write(byte[]) will invoke PrintStream overrides write(byte[], int, >> int) so IOE won't be thrown (and why the proposed change to the class >> description isn't right). The method description is probably the best place >> to describe the behavior. Here is an update which accounts for the foregoing comments. http://cr.openjdk.java.net/~bpb/8187898/webrev-alt.02/ Thanks, Brian
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Alan Bateman
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Alan Bateman
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Alan Bateman
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Lance Andersen
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: 8187898: PrintStream should override FilterOutputStre... Roger Riggs
- Re: 8187898: PrintStream should override FilterOutputStre... Brian Burkhalter
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... David Holmes
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... David Holmes
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Alan Bateman
- Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override... Brian Burkhalter
- Re: 8187898: PrintStream should override FilterOutputStre... Brian Burkhalter