+1 on the bug fix.
(I wouldn't spend time changing a bunch of tests that have a consistent
style of their own.
Having a few that look different is inconsistent and 'wrong'. And I
wouldn't fix even one of them.
No one is mechanically looking for @summary in these tests and its just
make-work.)
Roger
On 8/13/19 11:49 AM, Lance Andersen wrote:
Hi Naoto,
Thank you for adding the heading. you rock :-)
On Aug 13, 2019, at 11:06 AM, naoto.s...@oracle.com wrote:
Hi Lance,
I modified the headers of those two test cases as follows:
http://cr.openjdk.java.net/~naoto/8211990/webrev.01/
Didn't bother changing others :-)
Naoto
On 8/12/19 3:46 PM, Lance Andersen wrote:
Hi Naoto
On Aug 12, 2019, at 6:34 PM, naoto.s...@oracle.com
<mailto:naoto.s...@oracle.com> wrote:
Hi Lance,
Yes, I would like the style, but AFAIK, all java.time tests are testng, and
controlled with the java/time/{test/tck}/TEST.properties file so that each test
file won't need jtreg tags (it cannot override them either).
Yes the @build,@run, @library would be handled via the TEST.properties and are
not needed for the test because of TEST.properties.
The other tags are informational and do not impact the running of the test such
as @test, @bug, @summary….
Anyways, no big deal either way, just thought I would ask.
have a good evening
Best
lance
Naoto
On 8/12/19 3:17 PM, Lance Andersen wrote:
Hi Naoto,
On Aug 12, 2019, at 6:01 PM, naoto.s...@oracle.com <mailto:naoto.s...@oracle.com>
<mailto:naoto.s...@oracle.com> wrote:
Thank you for the review, Lance.
On 8/12/19 2:37 PM, Lance Andersen wrote:
Looks good Naoto.
One question I had which is not relevant to your fix, but should the tests as
we modify them include the JTReg tags such as @bug, @summary…. etc… just for
consistency….
I put @bug tags to each of the modified test, but not @summary, et.al. It seems that each
test file corresponds to the java.time class, so adding @summary for this bug might not
fit. I could add @summary to existing "Tests XXXX" statement, but keep it
consistent with other java.time test case files.
I was thinking more similar to:
open/test/jdk/jdk/nio/zipfs/TestPosix.java or
open/test/jdk/java/nio/file/Files/StreamTest.java
——————
/* @test
* @bug 8006884 8019526 8132539
* @library ..
* @build PassThroughFileSystem FaultyFileSystem
* @run testng StreamTest
* @summary Unit test for java.nio.file.Files methods that return a Stream
*/
————————
You won’t need the @run for these tests but each test is for a specific class
such as OffsetDateTime and ZonedOffSetDateTime and all of the bugs are listed
at the top of the file.
I am not sure we have agreed to standardize this historically, but I tend to
when I update a test if applicable.
Anyways, just a suggestion… Feel free to ignore ;-)
Have a good rest of your evening :-)
Naoto
Best
Lance
On Aug 12, 2019, at 4:43 PM, naoto.s...@oracle.com <mailto:naoto.s...@oracle.com>
<mailto:naoto.s...@oracle.com> <mailto:naoto.s...@oracle.com> wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8211990
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8211990/webrev.00/
The DateTimeException was thrown due to unconditional conversion beyond the valid range
of the internal LocalDateTime value. If it happens, normalize two instants with the
offset of "start" instant. The same kind of exception is observed with
ZonedDateTime.until(), which is also fixed in this changeset.
Naoto
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<mailto:lance.ander...@oracle.com> <mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>