Hi Julia, Brian > On Aug 14, 2019, at 12:08 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > Hi Julia, > > I think you need “@since 14” on the new StrictMath methods Yes, as these are new methods to this class the above would be correct vs 1.8
> . I don’t see any other problems. Looks OK to me For the CSR Compatibility Risk Assessment ————— New public static methods are added to java.lang.StrictMath, which is a class that can't be instantiated. The compatibility risk should be minimal. —————— There are new methods, so there is no compatibility risk. You might change to something similar as: _————— There is no compatibility risk as this proposal adds new static methods to java.lang.StrictMath ——————— For the specification, you may want to consider including the specdiff as an attachment, or what I do in some cases given it is a small set of additions, just paste the javadoc in the spec section. HTH Lance > > Thanks, > > Brian > >> On Aug 14, 2019, at 9:01 AM, Julia Boes <julia.b...@oracle.com> wrote: >> >> This fix adds decrementExact(), incrementExact(), and negateExact() to >> java.lang.StrictMath. The methods were added to java.lang.Math previously >> [1] and should have been added to java.lang.StrictMath for consistency. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8229485 >> <https://bugs.openjdk.java.net/browse/JDK-8229485> >> >> Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.01/ >> <http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.01/> >> >> CSR: https://bugs.openjdk.java.net/browse/JDK-8229702 >> <https://bugs.openjdk.java.net/browse/JDK-8229702> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
