A tiny addition:
On 8/14/19 10:56 AM, Ivan Gerasimov wrote:
Hi Julia!
In ExactArithTests.java
1)
169 long neg2 = -((long)x) ;
please remove the superfluous space at the end.
2)
176 long neg2 = (long) x - 1L;
should be `long neg2 = -((long)x);`
In StrictMath.java
3)
while you're here, could you please replace semicolon with comma:
916 * Returns the value of the {@code long} argument;
917 * throwing an exception if the value overflows an {@code int}.
In src/java.base/share/classes/java/lang/Math.java
4)
at line 1061
* Returns the value of the {@code long} argument;
* throwing an exception if the value overflows an {@code int}.
analogously to (3) above, could you please s/;/,/ ?
Thanks!
With kind regards,
Ivan
On 8/14/19 9:01 AM, Julia Boes wrote:
Hi,
This fix adds decrementExact(), incrementExact(), and negateExact()
to java.lang.StrictMath. The methods were added to java.lang.Math
previously [1] and should have been added to java.lang.StrictMath for
consistency.
Bug: https://bugs.openjdk.java.net/browse/JDK-8229485
Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.01/
CSR: https://bugs.openjdk.java.net/browse/JDK-8229702
Thanks,
Julia
[1] https://bugs.openjdk.java.net/browse/JDK-8022109
--
With kind regards,
Ivan Gerasimov
