2019/10/2 5:45:10 -0700, goetz.lindenma...@sap.com: > thanks for looking at my change! Can I add you as reviewer?
Sure. >> This is very nice work! I especially appreciate the thorough tests. > > Thanks! But adapting the many tests to changed messages is > quite cumbersome :) Thanks for supplying the patch right away! Nothing that a little Emacs-fu can’t handle. >> ... >> >> I also noticed that the generated messages use single quotes (‘'’) to >> quote the names of fields, etc., rather than double quotes (‘"’). > > I'm fine with this, but I think hotspot uses "'" for citing code > quite consistently. E.g., have a look at > http://hg.openjdk.java.net/jdk/jdk/file/b25362cec8ce/src/hotspot/share/interpreter/linkResolver.cpp > This can easily be changed. I could do a separate change > for hotspot and change all uses of ' in exceptions to ". What > do you think? I think that’d be a fine clean-up task, for later. - Mark
