On 10/8/2019 4:21 PM, Andy Herrick wrote:
On 10/8/2019 3:33 PM, Alexey Semenyuk wrote:
Andy,
AbstractAppImageBuilder.java: is extra ` + File.separator` by intention?
this was just trying to be consistent - doesn't matter to native code
who is only one to see this value - but I should probably change back.
WinMsiBundler.java: static cache will be a potential problem if
jpackage will be used as tool provider, i.e. in scenario when
jpackage will be called multiple times per jvm session.
??
it is only the versions of the tool that is static.
you think app will use ToolProvider to call jpackage, then wait while
user installs new version of WIX on system, then app will use
ToolProvider again ?
I suppose that is possible.
Yep, this is highly unlikely, but still possible.
Anyway - the code to get the wix tools version only once is not really
a part of this fix, just triggered by your desire to print out all of
the usage text from candle and light when getting their version with
--verbose option.
So I can remove that from this fix.
Just making the fields non static would be good, I guess.
- Alexey
/Andy
- Alexey
On 10/8/2019 3:06 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This change is to Expose the macro $APPDIR for use in --java-options
value, to rename macros to mean what they are called, and to
eliminate several unused macros.
[1] https://bugs.openjdk.java.net/browse/JDK-8231910
[2] http://cr.openjdk.java.net/~herrick/8231910/
/Andy
