On 10/31/19 9:08 PM, Jie Fu wrote:
Hi Mandy,
Thanks for your review and nice suggestion.
Updated: http://cr.openjdk.java.net/~jiefu/8233291/webrev.01/
Why do you need to check if it contains "debug"? I would expect it's
simply empty string or the "jdk.debug" system property value appended
with a space.
In any case, I'm okay with the generic pattern ".*build.*$" (webrev.00)
if preferred.
I had added '@requires vm.flavor == "server"' since the test is only
suitable for server VMs.
I think the test is not restricted for server VM. Is it because of the
"Server VM" check? Should that check be fixed instead?
[1]
http://hg.openjdk.java.net/jdk/jdk/file/tip/src/java.base/share/classes/java/lang/VersionProps.java.template#l217
Mandy
