Hi Jie,
On 11/2/19 4:46 AM, Jie Fu wrote:
Hi Mandy,
Thanks for your review and valuable comments.
Updated: http://cr.openjdk.java.net/~jiefu/8233291/webrev.02/
Looks good. I'll sponsor it.
Mandy
Testing:
----------------------------------
Ben="tools/jlink/plugins/VendorInfoPluginsTest.java"
make test TEST="${Ben}" CONF=server-release
make test TEST="${Ben}" CONF=fastdebug
make test TEST="${Ben}" CONF=slowdebug
make test TEST="${Ben}" CONF=minimal
make test TEST="${Ben}" CONF=zero
----------------------------------
Please review it and give me some advice.
Thanks a lot.
Best regards,
Jie
On 2019/11/2 上午1:15, Mandy Chung wrote:
Why do you need to check if it contains "debug"?
Because System.getProperty("jdk.debug") will return "release" for
release VMs and "{fast/slow}debug" for debug VMs.
I think the test is not restricted for server VM. Is it because of
the "Server VM" check?
Yes.
Should that check be fixed instead?
Fixed. Thanks.
