Hi Lance, thanks for reviewing. I've addressed your points:
> I would suggesting moving the code added to the constructor for checking > the releaseVersion/multi-release properties to a method and grouping it > with the other methods added for supporting MR jars around line 1396. > (keeps it easier to follow and maintain) Done that. > Could you also add a comment above the isMultiReleaseJar method to for > clarity going forward (I know there was not one there before) Done, too. > I might change the name of the lookup field in the method makeParentDirs > with the addition of the Function lookup on line 126. I chose to change the name of the global field in line 126 to be named mrlookup. Also updated the comment. This is the new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8234089.2/ Cheers Christoph
