On 3/12/2019 11:08 am, John Rose wrote:
On Dec 2, 2019, at 4:36 PM, David Holmes <david.hol...@oracle.com
<mailto:david.hol...@oracle.com>> wrote:
You are using CHECK_0 in RecordComponent::create but that method
returns oop. That seems wrong to me, but I see many other oop
returning methods also use CHECK_0 so I'll take that up separately.
(It's only a cosmetic issue.)
CHECK_NULL is clearly preferable. At some point IIRC it was more
than just cosmetics, because we were getting warning noise about
`return 0` converting to NULL, from some C++ compiler or other.
AFAIK such warnings can still happen.
That was my recollection too (I know we fixed some CHECK_0 ->
CHECK_FALSE usages for bool methods). I have filed:
https://bugs.openjdk.java.net/browse/JDK-8235225
to fix the existing code.
Vicente should make this change to his code before pushing (no need to
see new webrev).
Thanks,
David
— John
