Hi Alexey,

1) Remove this file:
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.rej
2) Agree with Phil, they probably should be pushed as two separate bugs.
3) Do you know how to run installer tests with new changes? It is not clear from code.

Changes itself looks fine.

Thanks,
Alexander

On 12/5/2019 5:33 PM, Philip Race wrote:
I don't understand the relationship between these two bugs.

-phil

On 12/5/19, 2:47 PM, Alexey Semenyuk wrote:
Please review  fixes for [1] and [2]. Both target jpackage tool.

The webrev is at [3].

[1] https://bugs.openjdk.java.net/browse/JDK-8233270

[2] https://bugs.openjdk.java.net/browse/JDK-8230933

[3] http://cr.openjdk.java.net/~asemenyuk/8233270/webrev.00/


Reply via email to