Hi Joe,

This seems OK. 

> On Jan 14, 2020, at 3:08 PM, Joe Wang <huizhe.w...@oracle.com 
> <mailto:huizhe.w...@oracle.com>> wrote:
> 
> Hi,
> 
> Please review an update to BCEL 6.4.1.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8235368 
> <https://bugs.openjdk.java.net/browse/JDK-8235368>
> webrev: http://cr.openjdk.java.net/~joehw/jdk15/8235368/webrev/index.html 
> <http://cr.openjdk.java.net/~joehw/jdk15/8235368/webrev/index.html>
> 
> Similar approach as the last update:
> 1. Format
>     All format changes are kept as they are in the source in order to reduce 
> the amount of changes in future updates, the exceptions are extreme long 
> lines.
> 
> 2. Exclusions
>     Contents that were not in the JDK or unnecessary for java.xml are 
> excluded. This includes: the ability to load arbitrary classes and classes 
> related to ClassLoader, ClassPath and JavaWrapper, and relevant methods and 
> references in other classes; System Properties used to set cache sizes and 
> track certain statistics (caches are set as in previous version); Deprecated 
> classes and related contents.
> 
> 3. Warnings
>     Warnings were the main reason for the changes made to the original 
> source. It has been done in the previous update. They are re-applied for this 
> update. The LastModified field indicates such changes to the original source.
> 
> 4. Deprecated fields to private and references to deprecated methods
>    Deprecated fields in the original source were changed to private ones in 
> previous update. References to deprecated methods were modified to use proper 
> methods. These changes are inherited in this update.
> 
> 5. Test
>     Since the update does not affect java.xml's usage of the BCEL component, 
> it is essential to pass all of the existing tests. I've run the tests 
> multiple times and noted that all of the XML functional and unit tests 
> passed, so were JCK XML tests. A performance test is running.
> 
> 
> Thanks,
> Joe
> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>



Reply via email to