Hi Mandy,
Updates seem fine to me.
Thanks,
David
On 10/03/2020 2:53 pm, Mandy Chung wrote:
Hi David,
On 3/9/20 7:41 PM, David Holmes wrote:
That's a core-libs decision but I'm not sure that's a namespace we
want to increase usage of.
I'm open to other suggestion. This helper method avoids the call to
doPrivileged when security manager is enabled and I think it's okay to
add this helper method in sun.security.action package.
Webrev:
http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8228336/webrev.00/
Overall refactoring looks okay to me. A couple of minor things I noticed:
src/java.base/share/classes/java/lang/ClassLoader.java
! " in java.library.path: " +
StaticProperty.sunBootLibraryPath());
s/java/sun.boot/
Thanks for catching this.
src/java.base/share/classes/java/lang/Runtime.java
I don't see the point in changing load0 and loadLibrary0 to return
NativeLibrary when it is unused. Is this to allow for direct use of
these methods in the future?
It was leftover from my early prototype. It's not intended to change.
I have fixed it.
This new webrev includes the above minor fixes and a few windows/solaris
specific files I missed from webrev.00:
http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8228336/webrev.01/index.html
Thanks
Mandy
