> On May 5, 2020, at 5:42 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Mikael, > > I spotted another place where a residual reference to Solaris > remains in a comment: > src/java.base/unix/native/libnet/PlainSocketImpl.c > > 857 #if defined(_AIX) > 858 if (errno == EINVAL) { > 859 // On Solaris setsockopt will set errno to EINVAL if the > socket > 860 // is closed. The default error message is then confusing Fixed in the upcoming webrev! > Otherwise I had a look at the networking related files and > the changes seemed reasonable to me. Thanks a lot for the review! Cheers, Mikael
- Re: RFR: 8244224: Implementation of JE... Mikael Vidstedt
- Re: RFR: 8244224: Implementation ... Magnus Ihse Bursie
- Re: RFR: 8244224: Implementation of JEP 381: Remov... Mikael Vidstedt
- Re: RFR: 8244224: Implementation of JEP 381: Remove the... Weijun Wang
- Re: RFR: 8244224: Implementation of JEP 381: Remov... Mikael Vidstedt
- Re: RFR: 8244224: Implementation of JEP 381: Remove the... naoto . sato
- Re: RFR: 8244224: Implementation of JEP 381: Remov... Mikael Vidstedt
- Re: RFR: 8244224: Implementation of JEP 381: Remove the... Brent Christian
- Re: RFR: 8244224: Implementation of JEP 381: Remov... Mikael Vidstedt
- Re: RFR: 8244224: Implementation of JEP 381: Remove the... Daniel Fuchs
- Re: RFR: 8244224: Implementation of JEP 381: Remov... Mikael Vidstedt
- Re: RFR: 8244224: Implementation of JEP 381: Remove the... Mikael Vidstedt
- Re: RFR: 8244224: Implementation of JEP 381: Remov... Alan Bateman
- Re: RFR: 8244224: Implementation of JEP 381: R... Mikael Vidstedt