Thanks Chris, Roger, and Mandy. I've updated the webrev using
AtomicInteger and removing java.base export.
Here's the updated webrev:
http://cr.openjdk.java.net/~joehw/jdk16/8248486/webrev/
-Joe
On 7/10/20 9:59 AM, Mandy Chung wrote:
Hi Joe,
The change looks good. You can consider using AtomicInteger for the
thread number. Looks like this is the only use of jdk.internal.misc
from java.xml. You can remove the qualified exports from java.base
to java.xml.
$ ./bin/jdeps -verbose:class -p jdk.internal.misc modules/java.xml
java.xml
:
java.xml -> java.base
com.sun.org.apache.xml.internal.utils.SafeThread ->
jdk.internal.misc.Unsafe java.base (qualified)
Mandy
On 7/10/20 9:38 AM, Chris Hegarty wrote:
On 9 Jul 2020, at 23:23, huizhe.w...@oracle.com wrote:
...
webrev: http://cr.openjdk.java.net/~joehw/jdk16/8248486/webrev/
Looks good. Reviewed.
-Chris.
