Mandy, Vladimir, thanks for your reviews, pushed to jdk15.
-- Igor > On Jul 18, 2020, at 9:33 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > +1 > > Mandy > > On 7/17/20 8:57 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00 >> <http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00> >>> 3 lines changed: 1 ins; 1 del; 1 mod; >> >> Hi all, >> >> could you please review this trivial patch which removes @ignore from >> LFGarbageCollectedTest and adds it into problem-list instead? >> >> from 8249698: >>> java/lang/invoke/LFCaching/LFGarbageCollectedTest.java is excluded from >>> execution due to JDK-8078602. although the test might indeed fail due to >>> JDK-8078602, it still can be useful and isn't harmful to run, therefore >>> this test should be put in ProblemList.txt and @ignore is to be removed. >> from main issue(8249618): >>> although ProblemList and @ignore achieve the same end result (test >>> exclusion), their server different goals and have slightly different >>> meanings, simplified @ignore should be used to exclude useless or harmful >>> tests, and ProblemList in all other cases (see yet-not-integrated >>> `ProblemListing or `@ignore`-ing a Test` section of dev guide, PR -- >>> https://github.com/openjdk/guide/pull/21 >>> <https://github.com/openjdk/guide/pull/21> for more details). >>> >>> due to different reasons, this hasn't been always followed and some >>> currently @ignore-d tests should rather be ProblemList-ed, and some of >>> ProblemList-ed should be @ignore-d, this issue is to clean up the current >>> state in a hope that this will reduce further confusion. >> >> webrev: http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00 >> <http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8249698 >> <https://bugs.openjdk.java.net/browse/JDK-8249698> >> >> Thanks, >> -- Igor >> >> 8078602: https://bugs.openjdk.java.net/browse/JDK-8078602 >> <https://bugs.openjdk.java.net/browse/JDK-8078602> >> 8249618: https://bugs.openjdk.java.net/browse/JDK-8249618 >> <https://bugs.openjdk.java.net/browse/JDK-8249618>
