Looks good. Minor suggestion, please change --- tstring getRealPath(std::vector<char> in) --- to --- tstring getRealPath(const std::vector<char>& in); ---
- Alexey On 8/7/2020 5:54 PM, [email protected] wrote:
Please review the jpackage fix for bug [1] at [2].- Fixed by converting path of executable to real path if _NSGetExecutablePath() returned symbolic link.[1] https://bugs.openjdk.java.net/browse/JDK-8248905 [2] http://cr.openjdk.java.net/~almatvee/8248905/webrev.00/ Thanks, Alexander
