Looks good.
- Alexey
On 8/7/2020 7:59 PM, alexander.matv...@oracle.com wrote:
Hi Alexey,
Webrev updated:
http://cr.openjdk.java.net/~almatvee/8248905/webrev.01/
Thanks,
Alexander
On 8/7/20 3:36 PM, Alexey Semenyuk wrote:
Looks good. Minor suggestion, please change
---
tstring getRealPath(std::vector<char> in)
---
to
---
tstring getRealPath(const std::vector<char>& in);
---
- Alexey
On 8/7/2020 5:54 PM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
- Fixed by converting path of executable to real path if
_NSGetExecutablePath() returned symbolic link.
[1] https://bugs.openjdk.java.net/browse/JDK-8248905
[2] http://cr.openjdk.java.net/~almatvee/8248905/webrev.00/
Thanks,
Alexander
