On Tue, 8 Sep 2020 19:44:21 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> 8252830: Correct missing javadoc comments in java.rmi module > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Added java.io.Serial to java.rmi.activation.ActivationID Marked as reviewed by smarks (Reviewer). src/java.rmi/share/classes/java/rmi/server/RemoteObject.java line 368: > 366: @java.io.Serial > 367: private void writeObject(java.io.ObjectOutputStream out) > 368: throws java.io.IOException It's a little odd to see an import of java.io.IOException (which is used by the `@throws` tag) but not to have it used here. There's another occurrence down below. These files have a mixture of imports and fully qualified names, which I find irritating, which might be nice to clean up. But you might find beyond the scope of this change. So, clean up as much of this as you like, or none if you prefer, no big deal. ------------- PR: https://git.openjdk.java.net/jdk/pull/79