On Wed, 9 Sep 2020 07:24:57 GMT, Chris Hegarty <che...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added java.io.Serial to java.rmi.activation.ActivationID > > Marked as reviewed by chegar (Reviewer). Hi Stuart, I'm going to leave this for later, its a bit out of scope and every change prompts the people who have already reviewed it to need to review it again. Thanks, Roger On 9/8/20 5:38 PM, Stuart Marks wrote: > > *@stuart-marks* commented on this pull request. > > ------------------------------------------------------------------------ > > In src/java.rmi/share/classes/java/rmi/server/RemoteObject.java > <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/79*discussion_r485210638__;Iw!!GqivPVa7Brio!OBTG2nlJMZowBn3gf_R72ZdA_MzJASDpLUuJFDC4fTAxUL_AnJ9Pfvctp470Fa4a$>: > > > */ > + @java.io.Serial > private void writeObject(java.io.ObjectOutputStream out) > throws java.io.IOException > > It's a little odd to see an import of java.io.IOException (which is > used by the |@throws| tag) but not to have it used here. There's > another occurrence down below. These files have a mixture of imports > and fully qualified names, which I find irritating, which might be > nice to clean up. But you might find beyond the scope of this change. > So, clean up as much of this as you like, or none if you prefer, no > big deal. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/79*pullrequestreview-484510521__;Iw!!GqivPVa7Brio!OBTG2nlJMZowBn3gf_R72ZdA_MzJASDpLUuJFDC4fTAxUL_AnJ9Pfvctp0HjkJMk$>, > or unsubscribe > <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAIRSVBO6NWK7WC75GOJRETSE2P67ANCNFSM4RAD5TXQ__;!!GqivPVa7Brio!OBTG2nlJMZowBn3gf_R72ZdA_MzJASDpLUuJFDC4fTAxUL_AnJ9Pfvctp5LhysgN$>. > ------------- PR: https://git.openjdk.java.net/jdk/pull/79
