On Thu, 24 Sep 2020 13:50:07 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> But test calls AdditionalLauncher.applyTo(JPackageCommand cmd), which does >> not have reference to PackageTest. Do you >> know why we need two applyTo()? > > Just change the test code to call AdditionalLauncher.applyTo(PackageTest): > `launcher1.applyTo(packageTest); > launcher2.applyTo(packageTest)` > > AdditionalLauncher.applyTo(JPackageCommand) is for non-packaging tests. Actually it will not work. I am running appImageCmd command before test executes to generate app image. If I add it to packageTest, jpackage will fail when trying to run command with app-image and launchers. ------------- PR: https://git.openjdk.java.net/jdk/pull/263
