On Thu, 24 Sep 2020 23:35:15 GMT, Alexander Matveev <almat...@openjdk.org> 
wrote:

>> Just change the test code to call AdditionalLauncher.applyTo(PackageTest):
>> `launcher1.applyTo(packageTest);
>> launcher2.applyTo(packageTest)`
>> 
>> AdditionalLauncher.applyTo(JPackageCommand) is for non-packaging tests.
>
> Actually it will not work. I am running appImageCmd command before test 
> executes to generate app image. If I add it to
> packageTest, jpackage will fail when trying to run command with app-image and 
> launchers.

I will keep addLauncherName() inside test to add launchers manually and will 
also call it in applyTo(PackageTest) for
future tests, that might use such functionality.

-------------

PR: https://git.openjdk.java.net/jdk/pull/263

Reply via email to