On Tue, 17 Nov 2020 02:01:32 GMT, Alexey Semenyuk <[email protected]> wrote:
>> In scenario 1, the installer would be Bar-1.0.{exe, msi, pkg ...}
>> The change in test above tests this.
>> Scenario 2 would be an error currently, since all jpackage commands require
>> a "--name" argument, however, it would be reasonable to modify restriction
>> to require either a name or an app-image, extracting the name from the
>> app-image in this case.
>
> I think we need to define the behavior we want from two phase jpackage runs
> first and create tests after that. I agree it would be good to extract name
> from app image if it is not specified explicitly when building an installer
I see that further changes are needed in jpackage code to properly handle all
cases of installer name vs application name.
I will open a new bug to fix all such cases, and include test cases
I will then close this bug as dupe of that, and I am closing this pull request
-------------
PR: https://git.openjdk.java.net/jdk/pull/1229
