On Thu, 19 Nov 2020 17:56:50 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> Poonam Bajaj has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Added UncheckedIOException catch blocks for cgroupv2 subsystem, and also 
>> for the rest of reader methods in CgroupUtil.java
>
> This looks good to me. @jerboaa might want to take a look.

Shouldn't you add a check in 
src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java:sumTokensIOStat
 ?

What about getLongEntry in 
src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java?
  There are streams operations occuring there as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1303

Reply via email to