On Thu, 19 Nov 2020 20:49:16 GMT, Poonam Bajaj <poo...@openjdk.org> wrote:
>> Hi, >> >> Please review this simple change that catches UncheckedIOException that can >> occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the >> system, or if there is an interrupt while these are being read. >> >> Testing: Tier1, Tier2 and Tier3. >> >> Thanks, >> Poonam > > Poonam Bajaj has updated the pull request incrementally with one additional > commit since the last revision: > > Added UnchedkedIOException catch blocks for sumTokensIOStat and > getLongEntry methods This seems OK. Ideally, I'd like for this to be tested. If it's interrupts it's going to be difficult. Missing files should be easy enough to test. Aside: We really need to streamline file reading. We have too many of them unnecessarily all over the place. [JDK-8254001](https://bugs.openjdk.java.net/browse/JDK-8254001) should fix that. I'll prioritize it. ------------- PR: https://git.openjdk.java.net/jdk/pull/1303
