On Tue, 1 Dec 2020 22:19:55 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added a test > > test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 77: > >> 75: .shouldHaveExitValue(0); >> 76: >> 77: // run with archive without the >> -Djdk.internal.lambda.disableEagerInitialization=true property > > Minor suggestion: make this test case in a separate > `testWithEagerInitializationEnabled` method. `testImpl` can be renamed to > `testWithEagerInitializationDisabled`. I also factored out the archive creation into the `createArchiveWithEagerInitializationEnabled` method. ------------- PR: https://git.openjdk.java.net/jdk/pull/1542
